fix(isMacAddress): improve regexes and options#1616
fix(isMacAddress): improve regexes and options#1616profnandaa merged 6 commits intovalidatorjs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1616 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 100 100
Lines 1796 1794 -2
=========================================
- Hits 1796 1794 -2
Continue to review full report at Codecov.
|
tux-tn
left a comment
tux-tn
left a comment
There was a problem hiding this comment.
Thank you @fedeci for your quick fix on this.
I can see that the issue here is related to the macAddressWithDots regex. The author forgot to escape the dot. I agree with your fix of the regex but I don't understand why you decided to change the behaviour (Hyphens and spaces are considered valid MAC Address separators) and the option name Introducing potential breaking changes (I know that no_colons is still supported in your code).
|
I thought it was possible to join multiple suggested changes in one commit🤦 |
|
Closing and re-opening to kick off Github actions. |
3 participants
Fixes #1614
This PR simplifies regexes, update the
no_colonsoption name tonoSeparators. FixesmacAddressWithDotsregex to only allow dots as separator.Checklist