[Fix] isIP validator patterns for IPv4 and IPv6 RegExp formats#1632
Merged
profnandaa merged 2 commits intovalidatorjs:masterfrom Apr 17, 2021
Merged
[Fix] isIP validator patterns for IPv4 and IPv6 RegExp formats#1632profnandaa merged 2 commits intovalidatorjs:masterfrom
isIP validator patterns for IPv4 and IPv6 RegExp formats#1632profnandaa merged 2 commits intovalidatorjs:masterfrom
Conversation
added 2 commits
March 19, 2021 14:24
Provide a more strict regular expression patterns for ipv4 and ipv6 formats. ✅ Closes: validatorjs#1626
Extend upon existing IP validator unit test, valid examples. Provide IPv6 test addresses including `%`. ✅ Closes: validatorjs#1626
ognjenjevremovic
changed the title
isIP validator patterns for IPv4 and IPv6 RegExp formats
Codecov Report
@@ Coverage Diff @@
## master #1632 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 100 100
Lines 1843 1811 -32
=========================================
- Hits 1843 1811 -32
Continue to review full report at Codecov.
|
tux-tn
approved these changes
Mar 19, 2021
Member
tux-tn
left a comment
tux-tn
left a comment
There was a problem hiding this comment.
Thank you for your PR @ognjenjevremovic 🎉 !
You managed to include many previously unhandled cases for IPv6 and your approach is more simple and clean than the old implementation of isIP .
Really great job!
tux-tn
added
ready-to-land
profnandaa
approved these changes
Apr 17, 2021
Member
profnandaa
left a comment
profnandaa
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contrib and welcome to the project! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1626
Changes
Checklist
After the changes I ensured that:
npm run lint, from the root directory,npm run testfrom the root directory,npm run buildfrom the root directory.Done