fix ReDOS in isEmail and isHSL#1651
Merged
profnandaa merged 5 commits intovalidatorjs:masterfrom Apr 20, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1651 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 100 101 +1
Lines 1847 1854 +7
=========================================
+ Hits 1847 1854 +7
Continue to review full report at Codecov.
|
profnandaa
approved these changes
Apr 20, 2021
Member
profnandaa
left a comment
profnandaa
left a comment
There was a problem hiding this comment.
Thanks for getting this in! LGTM.
Closed
This was referenced Oct 28, 2021
This was referenced Nov 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
isEmailandisHSLin order to prevent ReDOS attack described in #1597 and #1598 without changing the behaviour of both validators.mochahas also been updated to the latest version in order to prevent npm/yarn audit from displaying a warning (Mocha is used as a dev dependency, people using validator are not impacted)Checklist