feat(niceToHave): Export list of country codes that implement IBAN#1669
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1669 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 101 101
Lines 1854 1855 +1
=========================================
+ Hits 1854 1855 +1
Continue to review full report at Codecov.
|
Co-authored-by: Federico Ciardi <[email protected]>
src/index.js
Outdated
| import isISRC from './lib/isISRC'; | ||
|
|
||
| import isIBAN from './lib/isIBAN'; | ||
| import isIBAN, { locales as isIBANLocales } from './lib/isIBAN'; |
There was a problem hiding this comment.
May be calling them isIBANLocales could be a little misleading, might think it's a validator/function. Perhaps just drop the is?
There was a problem hiding this comment.
@profnandaa I see what you're saying, but I think it's more inline with the rest of the code to call it isIBANLocales
|
Check also the failing tests. |
@profnandaa pushed test fixes, could you please approve running the workflow? |
|
Hi @fedeci :) |
| import { locales as isAlphanumericLocales } from '../src/lib/isAlphanumeric'; | ||
| import { locales as isMobilePhoneLocales } from '../src/lib/isMobilePhone'; | ||
| import { locales as isFloatLocales } from '../src/lib/isFloat'; | ||
| import { locales as ibanCountryCodes } from '../src/lib/isIBAN'; |
There was a problem hiding this comment.
| import { locales as ibanCountryCodes } from '../src/lib/isIBAN'; | |
| import { locales as isIBANLocales } from '../src/lib/isIBAN'; |
I would name it isIBANLocales to align to the other one.
|
@fedeci got you, just made the change |
profnandaa
left a comment
profnandaa
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution.
NP! thanks for your help :) |
4 participants
Export a list of country codes implementing IBAN
Addressing issue #1570
Checklist