Fix/german mobile phone validation#1675
Closed
Burnett01 wants to merge 2 commits intovalidatorjs:masterfrom
Burnett01:fix/german-phone-validation
Closed
Fix/german mobile phone validation#1675Burnett01 wants to merge 2 commits intovalidatorjs:masterfrom Burnett01:fix/german-phone-validation
Burnett01 wants to merge 2 commits intovalidatorjs:masterfrom
Burnett01:fix/german-phone-validation
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1675 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 101 101
Lines 1854 1854
=========================================
Hits 1854 1854
Continue to review full report at Codecov.
|
Member
|
Sorry this was already addressed in #1679 and sorry for late review // but thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(isMobilePhone) german: Restrict leading zero when country code +49 is used
This PR ensures that german mobile phone numbers are deemed invalid when the country code (+49) is used with a leading 0.
Example:
Invalid: +4901575663214
Valid: +491575663214
See #1670
Checklist