feat(isMobilePhone): add Palestine ar-PS locale#1767
feat(isMobilePhone): add Palestine ar-PS locale#1767brendan-c wants to merge 5 commits intovalidatorjs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1767 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2029 2029
Branches 457 457
=========================================
Hits 2029 2029
Continue to review full report at Codecov.
|
tux-tn
left a comment
tux-tn
left a comment
There was a problem hiding this comment.
Hello @brendan-c and thank you for your PR! Can you please address my comment below?
src/lib/isMobilePhone.js
Outdated
| 'ar-LY': /^((\+?218)|0)?(9[1-6]\d{7}|[1-8]\d{7,9})$/, | ||
| 'ar-MA': /^(?:(?:\+|00)212|0)[5-7]\d{8}$/, | ||
| 'ar-OM': /^((\+|00)968)?(9[1-9])\d{6}$/, | ||
| 'ar-PS': /^(\+?970|0)5[8|9](\d{7})$/, |
There was a problem hiding this comment.
Isn't prefixes for mobile phone numbers 9 and 6 instead of 8? The only source i can find is this wikipedia article
There was a problem hiding this comment.
You could be correct. The information this was based on was from http://www.wtng.info/wtng-970-ps.html but it lists it's source as Paltel, which appears to no longer be a mobile carrier
tux-tn
added
🎉 first-pr
🧹 needs-update
tux-tn
left a comment
tux-tn
left a comment
There was a problem hiding this comment.
LGTM ! Thank you for your efforts 🎉
tux-tn
added
ready-to-land
|
@brendan-c - please fix the merge conflict and we should be good to go. |
profnandaa
added
the
mc-to-land
|
Your work is now merged here #1851 |
profnandaa
changed the title
3 participants
feat(isMobilePhone) add Palestine validation (ar-PS)
Checklist