feat(isMobilePhone): add Bhutan dz-BT locale#1770
Merged
profnandaa merged 6 commits intovalidatorjs:masterfrom Oct 31, 2021
Merged
feat(isMobilePhone): add Bhutan dz-BT locale#1770profnandaa merged 6 commits intovalidatorjs:masterfrom
profnandaa merged 6 commits intovalidatorjs:masterfrom
Conversation
Added mobile operator codes as well
Updated the test cases
tux-tn
previously approved these changes
Oct 18, 2021
Member
tux-tn
left a comment
There was a problem hiding this comment.
LGTM 🎉
Thank you for your PR @lakshayr003
Codecov Report
@@ Coverage Diff @@
## master #1770 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2054 2054
Branches 464 464
=========================================
Hits 2054 2054
Continue to review full report at Codecov.
|
Member
|
@lakshayr003 - pls fix the merge conflict on README and we should be good to go. |
Contributor
Author
|
@profnandaa, I have resolved the merge conflict. |
profnandaa
approved these changes
Oct 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Worked on adding a mobile phone validation for Bhutan (dz-BT)