Skip to content

feat(isMobilePhone): add Maldives dv-MV locale#1829

Closed
beprajwal wants to merge 3 commits intovalidatorjs:masterfrom
beprajwal:add-maldives-mobile-phone-locale
Closed

feat(isMobilePhone): add Maldives dv-MV locale#1829
beprajwal wants to merge 3 commits intovalidatorjs:masterfrom
beprajwal:add-maldives-mobile-phone-locale

Conversation

@beprajwal
Copy link
Contributor

@beprajwal beprajwal commented Oct 25, 2021

Add regex to validate Maldives mobile phone numbers.

Related to #1761

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 25, 2021 •
edited
Loading

Codecov Report

Merging #1829 (7a70ddb) into master (13651ea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1829   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2029      2029           
  Branches       457       457           
=========================================
  Hits          2029      2029
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13651ea...7a70ddb. Read the comment docs.

@beprajwal
Copy link
Contributor Author

beprajwal commented Oct 26, 2021 •
edited
Loading

Hi, @tux-tn can you please review this PR? Also this is part of my hacktoberfest, can you add the label for it. Thanks 😄

tux-tn
tux-tn requested changes Oct 27, 2021
View reviewed changes
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Prajwalrajbasnet

Thank you for your PR and sorry for the late review. I added a comment concerning your regex, can you please address it?

@tux-tn tux-tn added 🎉 first-pr 🧹 needs-update For PRs that need to be updated before landing labels Oct 27, 2021
@beprajwal beprajwal force-pushed the add-maldives-mobile-phone-locale branch from b80cefd to e0172fb Compare October 28, 2021 04:32
@beprajwal beprajwal force-pushed the add-maldives-mobile-phone-locale branch from e0172fb to 7a70ddb Compare October 28, 2021 04:37
@beprajwal beprajwal requested a review from tux-tn October 28, 2021 04:39
tux-tn
tux-tn approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thank you @Prajwalrajbasnet for making the necessary changes that fast 🎉

@tux-tn tux-tn added hacktoberfest-accepted ready-to-land For PRs that are reviewed and ready to be landed and removed 🧹 needs-update For PRs that need to be updated before landing labels Oct 28, 2021
@profnandaa
Copy link
Member

profnandaa commented Oct 30, 2021

@Prajwalrajbasnet -- pls fix the merge conflicts and we should be good to go. Thanks!

@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Oct 30, 2021
@profnandaa profnandaa changed the title feat(isMobilePhone): Add mobile phone validation locale for Maldives (dv-MV) feat(isMobilePhone): add Maldives dv-MV locale Oct 31, 2021
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
@beprajwal @profnandaa
feat(isMobilePhone): add Maldives dv-MV locale
9c1453a 
chore: squashed #1829

Add locale for Maldives in mobile phone validator

Add tests for mobile numbers validation of maldives locale i.e. dv-MV

Update readme to add Maldives locale (dv-MV) in isMobilePhone documentation
@profnandaa
Copy link
Member

profnandaa commented Oct 31, 2021

No worries, your commit is now included here #1851

@profnandaa profnandaa closed this Oct 31, 2021
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
@beprajwal @profnandaa
feat(isMobilePhone): add Maldives dv-MV locale
c96d805 
chore: squashed #1829

Add locale for Maldives in mobile phone validator

Add tests for mobile numbers validation of maldives locale i.e. dv-MV

Update readme to add Maldives locale (dv-MV) in isMobilePhone documentation
@beprajwal
Copy link
Contributor Author

beprajwal commented Oct 31, 2021

No worries, your commit is now included here #1851

Thanks @profnandaa, sorry for late reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tux-tn tux-tn tux-tn approved these changes

Assignees

No one assigned

Labels

🎉 first-pr hacktoberfest-accepted mc-to-land Just merge-conflict standing between the PR and landing. ready-to-land For PRs that are reviewed and ready to be landed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@beprajwal @profnandaa @tux-tn