Skip to content

Added isMobilePhone valid regex for 3 countries#1925

Merged
rubiin merged 2 commits intovalidatorjs:masterfrom
Mustafiz04:feature/all-country-regex
Jul 19, 2022
Merged

Added isMobilePhone valid regex for 3 countries#1925
rubiin merged 2 commits intovalidatorjs:masterfrom
Mustafiz04:feature/all-country-regex

Conversation

@Mustafiz04
Copy link
Contributor

@Mustafiz04 Mustafiz04 commented Feb 5, 2022

I have added valid regex for Afghanistan, Yemen and Western Sahara.
I will add more regex for missing countries mainly Caribbean and small Island.
Solved and added test for issue #1761

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Feb 5, 2022 •
edited
Loading

Codecov Report

Merging #1925 (fba9680) into master (c193fe5) will not change coverage.
The diff coverage is n/a.

❗ Current head fba9680 differs from pull request most recent head afdbd68. Consider uploading reports for the commit afdbd68 to get more accurate results

@@            Coverage Diff            @@
##            master     #1925   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       102    -2     
  Lines         2120      2072   -48     
  Branches       475       472    -3     
=========================================
- Hits          2120      2072   -48
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)
src/index.js 100.00% <0.00%> (ø)
src/lib/isIP.js 100.00% <0.00%> (ø)
src/lib/alpha.js 100.00% <0.00%> (ø)
src/lib/isURL.js 100.00% <0.00%> (ø)
src/lib/isTaxID.js 100.00% <0.00%> (ø)
src/lib/isBase32.js 100.00% <0.00%> (ø)
src/lib/isLength.js 100.00% <0.00%> (ø)
src/lib/isMagnetURI.js 100.00% <0.00%> (ø)
src/lib/isCreditCard.js 100.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c193fe5...afdbd68. Read the comment docs.

@Mustafiz04
Copy link
Contributor Author

Mustafiz04 commented Feb 5, 2022

@ezkemboi can you please review this PR ?

I apologise for being a little late for this PR because I was busy at work.
Could you please provide a place where I can learn regex because I'm having trouble developing regex for the Caribbean and tiny islands?

rubiin
rubiin approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

rubiin
rubiin previously approved these changes Feb 14, 2022
View reviewed changes
@rubiin rubiin added the mc-to-land Just merge-conflict standing between the PR and landing. label Jul 18, 2022
@rubiin rubiin merged commit 89949e7 into validatorjs:master Jul 19, 2022
@rubiin
Copy link
Member

rubiin commented Jul 19, 2022

Thankyou for the contribution 🎉

@profnandaa profnandaa mentioned this pull request Feb 2, 2023
Closed
@rntvicente rntvicente mentioned this pull request May 24, 2024
Open
@sahilpawar58 sahilpawar58 mentioned this pull request May 25, 2024
Open
@ChinmoyHembram ChinmoyHembram mentioned this pull request May 25, 2024
Open
@fossabot fossabot bot mentioned this pull request Oct 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rubiin rubiin rubiin approved these changes

Assignees

No one assigned

Labels

mc-to-land Just merge-conflict standing between the PR and landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mustafiz04 @rubiin