fix(isMobilePhone): update phone regex for Zambia#2037
fix(isMobilePhone): update phone regex for Zambia#2037imkrishh wants to merge 2 commits intovalidatorjs:masterfrom
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2037 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 104 104
Lines 2203 2308 +105
Branches 477 578 +101
==========================================
+ Hits 2203 2308 +105
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Hi @imkrishh, thanks for the PR. It looks like currently only the following ranges are assigned and valid, which your PR is implementing, so thanks! Also another reference for the future: https://goo.gl/maps/YbE5RygVAwBarQhj7 Justone thing, that I think still needs to be done ideally: Thanks! for future reference: |
pano9000
left a comment
There was a problem hiding this comment.
thank you.
looks good to me now :-)
However please note, I don't have any privileges in this project, so we will have to wait for two of the maintainers to review and merge this.
profnandaa
left a comment
There was a problem hiding this comment.
LGTM. can fix the merge conflict if possible, or I'll fix them during clean-up.
|
@imkrishh can you fix the merge conflicts |
|
Conflict fixed here - #2482 |
Updated Zambia phone number RegEx validator
Added support for new phone network provider for Zambia [ref-link]
077 - Airtel (New Serial #)
076 - MTN (New Serial #)
Checklist