Skip to content

refactor: change test files to prepare for #1874#2091

Merged
profnandaa merged 2 commits intovalidatorjs:masterfrom
WikiRik:WikiRik/refactor-testfiles
Jan 28, 2023
Merged

refactor: change test files to prepare for #1874#2091
profnandaa merged 2 commits intovalidatorjs:masterfrom
WikiRik:WikiRik/refactor-testfiles

Conversation

@WikiRik
Copy link
Member

@WikiRik WikiRik commented Oct 25, 2022 •
edited
Loading

This PR takes away some of the changes in #2075 and related PRs built on that which are needed to implement #1874. This way the PRs that build on this do not have unrelated changes to isAfter.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 25, 2022 •
edited
Loading

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (e01385a) compared to base (7bef722).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master     #2091   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          105       105           
  Lines         2335      2335           
  Branches       586       586           
=========================================
  Hits          2335      2335

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@WikiRik WikiRik mentioned this pull request Oct 25, 2022
Open
@WikiRik
Copy link
Member Author

WikiRik commented Oct 25, 2022

@pixelbucket-dev could you rebase on this? I've already updated the refactor of isAfter on this

braaar
braaar approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@braaar braaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

@braaar braaar mentioned this pull request Oct 26, 2022
Merged
3 tasks
@braaar
Copy link
Contributor

braaar commented Oct 26, 2022 •
edited
Loading

Would be really nice if we could merge this! That makes it a lot easier to review PRs like #2089

@pixelbucket-dev
Copy link
Contributor

pixelbucket-dev commented Oct 26, 2022

@tux-tn would you be able to approve so @WikiRik and I can move on with the other PRs? 😄

@pixelbucket-dev pixelbucket-dev mentioned this pull request Oct 27, 2022
Merged
3 tasks
@rubiin rubiin added the mc-to-land Just merge-conflict standing between the PR and landing. label Jan 21, 2023
@rubiin
Copy link
Member

rubiin commented Jan 23, 2023

@WikiRik mc is blocking the merge

@WikiRik
Copy link
Member Author

WikiRik commented Jan 23, 2023

@rubiin Fixed, thanks for the heads up! I'll review the PRs that allow usage of the options object after this has been merged and those PRs have been rebased

@rubiin rubiin added ✅ LGTM and removed mc-to-land Just merge-conflict standing between the PR and landing. labels Jan 23, 2023
profnandaa
profnandaa approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@profnandaa profnandaa merged commit 35b1fc1 into validatorjs:master Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@profnandaa profnandaa profnandaa approved these changes

@rubiin rubiin rubiin approved these changes

+2 more reviewers

@braaar braaar braaar approved these changes

@pixelbucket-dev pixelbucket-dev pixelbucket-dev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

✅ LGTM

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@WikiRik @braaar @pixelbucket-dev @rubiin @profnandaa