Remove redundant async feature from rust library#818
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #818 +/- ##
===========================================
+ Coverage 43.71% 43.78% +0.06%
===========================================
Files 259 259
Lines 20333 20333
Branches 2189 2189
===========================================
+ Hits 8888 8902 +14
+ Misses 11056 11040 -16
- Partials 389 391 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
caesay
force-pushed
the
cs/remove-rust-async
branch
from
3ce9402 to
282a469
Compare
caesay
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature is of limited value: it only wraps synchronous methods (does not actually provide real async) and consumers of this library may be using a different async runtime (tokio etc) so the methods cant be used anyway.