Misplaced comments about set_op_T and set_prefix_T#13249
Closed
zeertzjq wants to merge 1 commit intovim:masterfrom
Closed
Misplaced comments about set_op_T and set_prefix_T#13249zeertzjq wants to merge 1 commit intovim:masterfrom
zeertzjq wants to merge 1 commit intovim:masterfrom
Conversation
Problem: Misplacd comments about set_op_T and set_prefix_T. Solution: Correct the comments. Fix a typo in another comment.
Member
Author
|
Maybe this can be included along with #13237. |
Codecov Report
@@ Coverage Diff @@
## master #13249 +/- ##
=======================================
Coverage 82.16% 82.16%
=======================================
Files 160 160
Lines 196139 196139
Branches 43951 43951
=======================================
+ Hits 161149 161167 +18
+ Misses 22126 22105 -21
- Partials 12864 12867 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
|
Combining the commits sound good. |
Member
|
appreciate it, thanks! |
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Oct 2, 2023
Problem: Clean up cmdline option completion code Solution: Fix various minor problems - Fix manual array size calculations to just use `ARRAY_LENGTH()`. - Fix unintentional typo in comments due to copy-paste error. - Fix assert_equal() usages to pass the expected value to first parameter instead of 2nd one to avoid confusion. - Fix signed vs unsigned warnings - Correct misplaced comments about set_op_T and set_prefix_T and fix a typo in another comment closes: vim/vim#13249 closes: vim/vim#13237 vim/vim@6d11347 N/A patch: vim-patch:9.0.1976: style: space before tab in optionstr.c Co-authored-by: Yee Cheng Chin <[email protected]>
zeertzjq
added a commit
to neovim/neovim
that referenced
this pull request
Oct 2, 2023
Problem: Clean up cmdline option completion code Solution: Fix various minor problems - Fix manual array size calculations to just use `ARRAY_LENGTH()`. - Fix unintentional typo in comments due to copy-paste error. - Fix assert_equal() usages to pass the expected value to first parameter instead of 2nd one to avoid confusion. - Fix signed vs unsigned warnings - Correct misplaced comments about set_op_T and set_prefix_T and fix a typo in another comment closes: vim/vim#13249 closes: vim/vim#13237 vim/vim@6d11347 N/A patch: vim-patch:9.0.1976: style: space before tab in optionstr.c Co-authored-by: Yee Cheng Chin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Misplacd comments about set_op_T and set_prefix_T.
Solution: Correct the comments. Fix a typo in another comment.