Update plugconf examples function names#271
Conversation
Release v0.3.5
Release v0.3.5a
- Replaced s:config() with s:on_load_pre() and s:on_load_post()
|
Please change target branch to |
Thanks for the fix #275 ! 😄
Okay, so could you file an another issue? |
Co-Authored-By: hupfdule <[email protected]>
Co-Authored-By: hupfdule <[email protected]>
|
Thanks! |
I noticed a (non-functional) difference between the example in the README and the actual plugconf template: In the README the comments for the plugconf functions are written at the top of the function definition. In the actual template they are witten inside the function defintion.
I actually think putting them on top of the function definition makes more sense, since otherwise they cannnot easily be differentiated to the comments the user adds into the function defintion. Maybe the template should be changed to put the comments on top of the functions?
And another thing: While it makes utter sense to differentiate between configuration that has to be done before loading and configuration that has to be done after loading, the function names
s:on_load_preands:on_load_postaren't as nice ass:config.s:configmakes it clear that it is intended to be used for configuration settings.s:on_load_preands:on_load_postactually do make clear when they are being executed, but the intention isn't that clear anymore. Nevertheless, I don't have a suggestion for better names at the moment. :-) Just wanted to bring it to the table. Maybe someone else has an idea if those could functions could be better named.