Skip to content

agent: StrictPeers: only check host, not port#84

Merged
shazow merged 2 commits intomasterfrom
strictpeers-noport
Nov 15, 2019
Merged

agent: StrictPeers: only check host, not port#84
shazow merged 2 commits intomasterfrom
strictpeers-noport

Conversation

@shazow
Copy link
Member

@shazow shazow commented Nov 15, 2019

We were looking at RemotePort which is often an ephemeral port established during the UDP connection. It's not predictable or useful to check, and was causing a lot of StrictPeers thrashing.

@shazow shazow requested a review from ryanschneider November 15, 2019 00:25
Copy link
Collaborator

@ryanschneider ryanschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@shazow shazow merged commit 260b86f into master Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants