Skip to content

ExecuteAsyncScript: Only check for thenable #332 #333

Merged
vmi merged 2 commits intovmi:masterfrom
blutorange:issue-332
Mar 30, 2022
Merged

ExecuteAsyncScript: Only check for thenable #332 #333
vmi merged 2 commits intovmi:masterfrom
blutorange:issue-332

Conversation

@blutorange
Copy link
Contributor

@blutorange blutorange commented Mar 30, 2022

  • Fixes ExecuteAsyncScript not working with Firefox #332, see there for more details
  • Add test cases for executeAsyncScript to illustrate the issue with Firefox
  • Only check whether promise is thenable, e.g. whether it is truthy and has a then property of type function

@vmi vmi merged commit d717151 into vmi:master Mar 30, 2022
@vmi vmi self-requested a review March 30, 2022 10:18
@blutorange
Copy link
Contributor Author

That was quick, thanks. Doesn't have to be immediate, but it would great if you could make a patch release during the next few weeks.

@vmi
Copy link
Owner

vmi commented Apr 3, 2022

@blutorange I released 4.1.0.
Please check it out.

@blutorange
Copy link
Contributor Author

@vmi I just tried it with our tests and it works now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ExecuteAsyncScript not working with Firefox

2 participants