Skip to content

Change aria-errormessage to ID reference list#1802

Merged
spectranaut merged 1 commit intow3c:mainfrom
mrego:errormessage
Jan 11, 2023
Merged

Change aria-errormessage to ID reference list#1802
spectranaut merged 1 commit intow3c:mainfrom
mrego:errormessage

Conversation

@mrego
Copy link
Member

@mrego mrego commented Sep 15, 2022 •
edited by pr-preview bot
Loading

Fixes #1730.

Changes aria-errormessage to be an ID reference list

PR tracking

  • Related Core AAM PR:
  • Related AccName PR:
  • Related APG PR:
  • Any other dependent changes?

Implementation tracking

  • validator tests
  • WPT tests: LINK
  • Browser implementations (link to issue or when done, link to commit):
    • WebKit: Implemented
    • Gecko: Implemented
    • Blink: ISSUE
  • Does this need AT implementations?

Preview | Diff

@mrego mrego mentioned this pull request Sep 15, 2022
Closed
@cyns
Copy link
Contributor

cyns commented Sep 16, 2022

In Core-AAM it already has multiple references for IA2 and ATK/ATSPI.
Windows UI uses ControllerFor, which takes an array of references, so that can work

AX API (Mac) uses a text property and may not be able to support this.
@cookiecrook can this get text from multiple elements? Property: AXValidationError: textual content of the referenced element

@cyns cyns requested review from cookiecrook and cyns September 16, 2022 22:34
@cyns cyns mentioned this pull request Sep 16, 2022
Closed
cyns
cyns approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@cyns cyns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also w3c/core-aam#138 to make core-aam align with this change

@jnurthen
Copy link
Member

jnurthen commented Sep 22, 2022

@jcsteh can you please take a look at this.

@cookiecrook
Copy link
Contributor

cookiecrook commented Sep 29, 2022 •
edited
Loading

AX API (Mac) uses a text property and may not be able to support this. @cookiecrook can this get text from multiple elements? Property: AXValidationError: textual content of the referenced element

Yes, WebKit could concatenate the text equivalents into the string for the API, or the API owners could consider a change.

@mrego mrego mentioned this pull request Dec 22, 2022
Closed
@spectranaut
Copy link
Contributor

spectranaut commented Dec 22, 2022 •
edited
Loading

@jnurthen do you want @jcsteh's review?

I have a memory of discussing this in a meeting but I just looked through sept and oct meetings and didn't see anything. Should we agenda+ for a meeting in Jan, or do you remember discussing it?

@mrego
Copy link
Member Author

mrego commented Dec 22, 2022

BTW, filled issues on Chromium and Firefox.

@spectranaut
Copy link
Contributor

spectranaut commented Jan 10, 2023

Needs WPT test and link to webkit issue before merging.

@mrego
Copy link
Member Author

mrego commented Jan 10, 2023

Needs WPT test and link to webkit issue before merging.

WebKit already supports an ID reference list, so I guess we don't need an issue for that.

rniwa added a commit to rniwa/web-platform-tests that referenced this pull request Jan 11, 2023
@rniwa
Replace ARIA reflection attribute ariaErrorMessageElement with ariaEr…
2c550ee 
…rorMessageElements

This is WPT updates for w3c/aria#1802
@rniwa rniwa mentioned this pull request Jan 11, 2023
Merged
@cookiecrook
Copy link
Contributor

cookiecrook commented Jan 11, 2023

Thanks @rniwa for web-platform-tests/wpt#37856

@spectranaut, I think this can be merged now?

rniwa added a commit to rniwa/web-platform-tests that referenced this pull request Jan 11, 2023
@rniwa
Replace ARIA reflection attribute ariaErrorMessageElement with ariaEr…
2948659 
…rorMessageElements

This is WPT updates for w3c/aria#1802
rniwa added a commit to rniwa/web-platform-tests that referenced this pull request Jan 11, 2023
@rniwa
Replace ARIA reflection attribute ariaErrorMessageElement with ariaEr…
ce6f026 
…rorMessageElements

This is WPT updates for w3c/aria#1802
@spectranaut spectranaut merged commit 11c8909 into w3c:main Jan 11, 2023
github-actions bot added a commit that referenced this pull request Jan 11, 2023
@mrego @github-actions
Change aria-errormessage to ID reference list (#1802)
1be9acc 
SHA: 11c8909
Reason: push, by spectranaut

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@jcsteh
Copy link

jcsteh commented Jan 12, 2023

Sorry I didn't get around to reviewing this before it was merged. FWIW, this looks good to me.

rniwa added a commit to web-platform-tests/wpt that referenced this pull request Jan 12, 2023
@rniwa
Replace ARIA reflection attribute ariaErrorMessageElement with ariaEr…
b2408e7 
…rorMessageElements (#37856)

This is WPT updates for w3c/aria#1802
@mrego mrego deleted the errormessage branch January 13, 2023 09:38
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jan 19, 2023
@rniwa @moz-wptsync-bot
Bug 1809563 [wpt PR 37856] - Replace ARIA reflection attribute ariaEr…
fc6acf7 
…rorMessageElement with ariaErrorMessageElements, a=testonly

Automatic update from web-platform-tests
Replace ARIA reflection attribute ariaErrorMessageElement with ariaErrorMessageElements (#37856)

This is WPT updates for w3c/aria#1802
--

wpt-commits: b2408e7967806c7ad7691dae706f60ab463d17e6
wpt-pr: 37856
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Jan 20, 2023
@rniwa @moz-wptsync-bot
Bug 1809563 [wpt PR 37856] - Replace ARIA reflection attribute ariaEr…
298d569 
…rorMessageElement with ariaErrorMessageElements, a=testonly

Automatic update from web-platform-tests
Replace ARIA reflection attribute ariaErrorMessageElement with ariaErrorMessageElements (#37856)

This is WPT updates for w3c/aria#1802
--

wpt-commits: b2408e7967806c7ad7691dae706f60ab463d17e6
wpt-pr: 37856
@sivakusayan sivakusayan mentioned this pull request May 22, 2023
Open
aarongable pushed a commit to chromium/chromium that referenced this pull request Jul 19, 2023
@sivakusayan
Implement support for multiple IDREFs in aria-errormessage
5564249 
Supported starting in WAI-ARIA 1.3.
w3c/aria#1802

Bug: 1403266
Change-Id: I5e3892e798f78acb8d99ff89d5bba76e12a9e2f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604466
Reviewed-by: David Tseng <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Reviewed-by: Nektarios Paisios <[email protected]>
Reviewed-by: Xiaocheng Hu <[email protected]>
Commit-Queue: Aaron Leventhal <[email protected]>
Reviewed-by: Anastasia Helfinstein <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1172297}
jnurthen pushed a commit that referenced this pull request Oct 10, 2023
@mrego @jnurthen
Change aria-errormessage to ID reference list (#1802)
deceef5
jwidar pushed a commit to jwidar/LatencyZeroGithub that referenced this pull request Sep 16, 2025
@rniwa @moz-wptsync-bot
Bug 1809563 [wpt PR 37856] - Replace ARIA reflection attribute ariaEr…
aed6914 
…rorMessageElement with ariaErrorMessageElements, a=testonly

Automatic update from web-platform-tests
Replace ARIA reflection attribute ariaErrorMessageElement with ariaErrorMessageElements (#37856)

This is WPT updates for w3c/aria#1802
--

wpt-commits: b2408e7967806c7ad7691dae706f60ab463d17e6
wpt-pr: 37856
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cookiecrook cookiecrook cookiecrook approved these changes

@adampage adampage adampage approved these changes

@cyns cyns cyns approved these changes

Assignees

No one assigned

Labels

Agenda

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Should aria-errormessage be an ID reference list rather than a single reference?

7 participants

@mrego @cyns @jnurthen @cookiecrook @spectranaut @jcsteh @adampage