[css-fonts][css-multicol][css-scroll-anchoring][css-scrollbars][css-shapes][css-size-adjust][css-transforms][css-ui] Update Computed Value and Animation lines to new format.#3198
[css-fonts][css-multicol][css-scroll-anchoring][css-scrollbars][css-shapes][css-size-adjust][css-transforms][css-ui] Update Computed Value and Animation lines to new format.#3198frivoal merged 2 commits intow3c:masterfrom tabatkins:fix-propdefs
Conversation
upsuper
left a comment
upsuper
left a comment
There was a problem hiding this comment.
The changes to css-scrollbars look good to me.
svgeesus
left a comment
svgeesus
left a comment
There was a problem hiding this comment.
Changes to fonts 4 look good to me.
Changes to fonts 3 (Fonts.html) look fine too but will need to be merged in as errata first (and manually, because the .src.html diverged from the final version of the spec).
|
Multicol 1 & 2, as well as css-ui 3 and 4 OK, except for 1 comment: #3198 (comment) |
|
@svgeesus Could you clarify if you're requesting changes to this patch before merging, or if your comment is about something else that needs to happen outside of the changes to these files in this repository? (IIRC I edited the .src.html source and the .html output directly so whatever's in sync or not is still in sync or not as before.) |
|
I'm not requesting changes to the patch. I'm just saying that updating the files here doesn't update the Rec, and that the .src.html format is a pain in the ass. (sent in a hurry while on vacation) |
dbaron
left a comment
dbaron
left a comment
There was a problem hiding this comment.
css-size-adjust change looks fine
astearns
left a comment
astearns
left a comment
There was a problem hiding this comment.
LGTM, one nitpick you can fix or leave as-is
…hapes][css-size-adjust][css-transforms][css-ui] Update Computed Value and Animation lines to new format.
|
Fixed the things that were asked for during the review, and resolved the conflicts. Merging. |
|
@svgeesus , It's your turn to deal with fonts-3, as you mentioned in #3198 (comment) |
8 participants
Update a bunch of propdefs' Computed Value and Animation lines to the new format.
@litherum @frivoal @dirkschulze @rachelandrew @upsuper @astearns @dbaron Please review your respective specs; we'll merge when everyone gets a review in.