Allow SourceMapDevToolPlugin.append option to be a function#11497
Closed
okmttdhr wants to merge 3 commits intowebpack:mainfrom
Closed
Allow SourceMapDevToolPlugin.append option to be a function#11497okmttdhr wants to merge 3 commits intowebpack:mainfrom
okmttdhr wants to merge 3 commits intowebpack:mainfrom
Conversation
Contributor
|
For maintainers only:
|
okmttdhr
force-pushed
the
improve/source-map-file-customizable
branch
from
f1de8fc to
1f79175
Compare
So that source-map could be better customized. See webpack#783
okmttdhr
force-pushed
the
improve/source-map-file-customizable
branch
2 times, most recently
from
7eab964 to
22aa515
Compare
okmttdhr
force-pushed
the
improve/source-map-file-customizable
branch
from
89ede48 to
6867392
Compare
Contributor
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Contributor
|
It looks like this Pull Request doesn't include enough test cases (based on Code Coverage analysis of the PR diff). A PR need to be covered by tests if you add a new feature (we want to make sure that your feature is working) or if you fix a bug (we want to make sure that we don't run into a regression in future). @okmttdhr Please check if this is appliable to your PR and if you can add more test cases. Read the test readme for details how to write test cases. |
Member
|
@snitin315 Just a small job - resend it 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#783
Allow
SourceMapDevToolPlugin'sappendoption to be a function so that source-map could be better customized. #783 (comment)(Though it seems that
SourceMapDevToolPluginmight be able to solve the URL issue with thepublicPathandappendoptions).What kind of change does this PR introduce?
feature
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
Allow
SourceMapDevToolPlugin'sappendoption to be a functionhttps://webpack.js.org/plugins/source-map-dev-tool-plugin/#options
I didn't change the behavior, but maybe
EvalSourceMapDevToolPluginalso. Because settingappendoption tofalsedoesn't disable the appending but just set the default value ("//# sourceURL=[module]\n//# sourceMappingURL=[url]").https://webpack.js.org/plugins/eval-source-map-dev-tool-plugin/