Skip to content

81 Separate concepts of level and indent#85

Merged
wellle merged 1 commit intomasterfrom
81-custom-indent-functions
Aug 27, 2020
Merged

81 Separate concepts of level and indent#85
wellle merged 1 commit intomasterfrom
81-custom-indent-functions

Conversation

@wellle
Copy link
Owner

@wellle wellle commented Aug 27, 2020

Use new level to group context lines in order to limit lines per level.
Keep indent to display context lines.

Update custom indent function interface to return both of these values instead of just the indent. That way custom indent functions can handle special levels while still using the default indent() for displaying purposes.

Another issue introduced in #81, reported in #69 (comment).

Close #69 again.

⚠️ This is a breaking change as it changes the interface of the custom indent functions. See the changes in the README. I just updated the linked example, see #45 (comment).

So if you use custom indent functions you will have to update them to return both the logical level and the physical indent (to be used for displaying purposes)

Use new level to group context lines in order to limit lines per level.
Keep indent to display context lines.

Update custom indent function interface to return both of these values
instead of just the indent. That way custom indent functions can handle
special levels while still using the default indent() for displaying
purposes.
@wellle wellle merged commit 4301c96 into master Aug 27, 2020
@wellle wellle deleted the 81-custom-indent-functions branch August 27, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

line number and jumping to context line

1 participant