🤖 User test baselines have changed for fix-inference-to-multiple-symbol-instances#52
Closed
Conversation
…oft#35743) * Fixes JSX attribute escaping when parent pointers are missing * Fix whitespace change
andrewbranch
pushed a commit
that referenced
this pull request
Sep 30, 2021
* es private fields in in (#52) add support for the 'private-fields-in-in' TC39 proposal Signed-off-by: Ashley Claymore <[email protected]> * [fixup] include inToken when walking forEachChild(node, cb) * [squash] re-accept lib definition baseline changes * [squash] reduce if/else to ternary Signed-off-by: Ashley Claymore <[email protected]> * [squash] drop 'originalName' and rename parameter instead Signed-off-by: Ashley Claymore <[email protected]> * [squash] extend spelling suggestion to all privateIdentifiers Signed-off-by: Ashley Claymore <[email protected]> * [squash] revert the added lexical spelling suggestions logic Signed-off-by: Ashley Claymore <[email protected]> * [squash] update baseline Signed-off-by: Ashley Claymore <[email protected]> * [squash] inline variable as per PR suggestion Signed-off-by: Ashley Claymore <[email protected]> * [squash] test targets both esnext and es2020 as per PR comment Signed-off-by: Ashley Claymore <[email protected]> * switch to using a binary expression Signed-off-by: Ashley Claymore <[email protected]> * [squash] PrivateIdentifier now extends PrimaryExpression Signed-off-by: Ashley Claymore <[email protected]> * [squash] accept public api baseline changes Signed-off-by: Ashley Claymore <[email protected]> * [squash] classPrivateFieldInHelper now has documentation Signed-off-by: Ashley Claymore <[email protected]> * [squash] type-check now follows existing in-expression path Signed-off-by: Ashley Claymore <[email protected]> * [squash] parser now follows existing binaryExpression path Signed-off-by: Ashley Claymore <[email protected]> * [squash] correct typo in comment Signed-off-by: Ashley Claymore <[email protected]> * [squash] no longer use esNext flag Signed-off-by: Ashley Claymore <[email protected]> * [squash] swap 'reciever, state' helper params Signed-off-by: Ashley Claymore <[email protected]> * [squash] remove change to parenthesizerRules Signed-off-by: Ashley Claymore <[email protected]> * [squash] apply suggested changes to checker Signed-off-by: Ashley Claymore <[email protected]> * [squash] remove need for assertion in fixSpelling Signed-off-by: Ashley Claymore <[email protected]> * [squash] improve comment hint in test Signed-off-by: Ashley Claymore <[email protected]> * [squash] fix comment typos Signed-off-by: Ashley Claymore <[email protected]> * [squash] add flow-test for Foo | FooSub | Bar Signed-off-by: Ashley Claymore <[email protected]> * [squash] add checkExternalEmitHelpers call and new test case Signed-off-by: Ashley Claymore <[email protected]> * [squash] simplify and correct parser Signed-off-by: Ashley Claymore <[email protected]> * [squash] move most of the added checker logic to expression level Signed-off-by: Ashley Claymore <[email protected]> * [squash] always error when privateId could not be resolved Signed-off-by: Ashley Claymore <[email protected]> * [squash] reword comment Signed-off-by: Ashley Claymore <[email protected]> * [squash] fix codeFixSpelling test Signed-off-by: Ashley Claymore <[email protected]> * [squash] do less work Signed-off-by: Ashley Claymore <[email protected]> * store symbol by priateId not binaryExpression Signed-off-by: Ashley Claymore <[email protected]> * moved parsePrivateIdentifier into parsePrimaryExpression Signed-off-by: Ashley Claymore <[email protected]> * [squash] checkInExpressionn bails out early on silentNeverType Signed-off-by: Ashley Claymore <[email protected]> * [squash] more detailed error messages Signed-off-by: Ashley Claymore <[email protected]> * [squash] resolves conflict in diagnosticMessages.json Signed-off-by: Ashley Claymore <[email protected]> * [squash] update baseline for importHelpersES6 Signed-off-by: Ashley Claymore <[email protected]> * [squash] remove redundent if and comment from parser Signed-off-by: Ashley Claymore <[email protected]> * [squash] split up grammar/check/symbolLookup Signed-off-by: Ashley Claymore <[email protected]> * [squash] reword message for existing left side of in-expression error Signed-off-by: Ashley Claymore <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test run was triggerd by a request on microsoft#31633
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham