This repository was archived by the owner on Aug 22, 2023. It is now read-only.
Update some project files to SDK-style.#2
Merged
KirillOsenkov merged 1 commit intoxamarin:masterfrom Feb 9, 2021
Merged
Conversation
Author
|
@KirillOsenkov You touched this repo last! Can you review and merge this? Or point me to someone who can? Thanks! |
| <ProductVersion>8.0.30703</ProductVersion> | ||
| <SchemaVersion>2.0</SchemaVersion> | ||
| <SignAssembly>true</SignAssembly> | ||
| <TargetFramework>net40</TargetFramework> |
Member
There was a problem hiding this comment.
Any reason to target net40? Ideally it's net472.
KirillOsenkov
approved these changes
Feb 9, 2021
Member
KirillOsenkov
left a comment
KirillOsenkov
left a comment
There was a problem hiding this comment.
If it builds, it's good!
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
ICSharpCode.NRefactory.csprojandICSharpCode.NRefactory.CSharp.csprojto SDK style projects.The unit tests in Xamarin.Android use these assemblies along with the Mono debugging assemblies to ensure that changes do not break the ability to debug XA applications.
In order to target .NET 5/6 we need to build with
dotnet build, which requires SDK style projects.There does not seem to be CI for this repo. I tested by building locally as well as running the XA CI against this change: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4453779.