Foreign key cascade#1056
Merged
parsonsmatt merged 2 commits intoyesodweb:matt/cascade-mergefrom Mar 30, 2020
Merged
Conversation
kderme
commented
Mar 19, 2020
Comment on lines
+914
to
+915
| errorPrefix :: String | ||
| errorPrefix = "invalid foreign key constraint on table[" ++ show tableName ++ "] " |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| errorPrefix :: String | |
| errorPrefix = "invalid foreign key constraint on table[" ++ show tableName ++ "] " | |
| mkError :: String -> a | |
| mkError str = error $ conat ["invalid foreign key constraint on table[", show tableName, "] ", str] |
Maybe this is cleaner to use
parsonsmatt
approved these changes
Mar 30, 2020
Collaborator
parsonsmatt
left a comment
parsonsmatt
left a comment
There was a problem hiding this comment.
I dig it. I'm going to merge this into a branch and provide Postgresql/MySQL support. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to fix #910. It works only for table constaints and not for field constraints. Also it only works and is tested on SQLite, but I think making postgres work is just a matter of copy-pase. No existing migrations break.
Some of the options, like 'OnDeleteSetNull' are not useful at the moment, because of the limitation of persistent to only make possible to refer to primary keys of other tables (which can't be NULL anyway).
Not to be confused with what
mkDeleteCascadedoes. The approach here is to let the db do all the cascading changes, instead of manually updating other tables.Before submitting your PR, check that you've:
@sincedeclarations to the HaddockAfter submitting your PR: