Refactor PostgresJSON Tests#1072
Merged
parsonsmatt merged 14 commits intoyesodweb:masterfrom Apr 15, 2020
Merged
Conversation
parsonsmatt
requested changes
Apr 12, 2020
Collaborator
parsonsmatt
left a comment
parsonsmatt
left a comment
There was a problem hiding this comment.
Great first pass! I think we can make some further improvements and that'll help.
Co-Authored-By: Matt Parsons <[email protected]>
…istent into json-postgres-tests
Contributor
Author
|
@parsonsmatt I made the changes you request. I ended up just making all the tests work with the same setup, as I was having trouble adding a second |
parsonsmatt
approved these changes
Apr 15, 2020
Collaborator
|
Fantastic, thanks! This is great work 😄 If you'd like, you can add a |
Collaborator
|
awesome thanks! |
Contributor
Author
|
Thanks for your guidance on this Matt, I really appreciate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wasn't sure how to put all of the db entry keys into scope. I made some ad hoc data structures to do so, but if anyone has any suggestions on how to do this better I would be open to them!
Before submitting your PR, check that you've:
Bumped the version numberDocumented new APIs with Haddock markupAdded@sincedeclarations to the HaddockAfter submitting your PR:
Update the Changelog.md file with a link to your PR