Remove deriving of Typeable.#1114
Merged
MaxGabriel merged 1 commit intoyesodweb:masterfrom Aug 23, 2020
kukimik:remove_deriving_typeable
Merged
Remove deriving of Typeable.#1114MaxGabriel merged 1 commit intoyesodweb:masterfrom kukimik:remove_deriving_typeable
MaxGabriel merged 1 commit intoyesodweb:masterfrom
kukimik:remove_deriving_typeable
Conversation
Member
|
This looks great to me, thanks! |
Member
|
Ok, I released |
Collaborator
|
@MaxGabriel You're on for
|
Collaborator
|
It looks like @psibi uploaded recently, so could probably add to the Hackage repo |
Member
|
@MaxGabriel / @parsonsmatt Added both of you to the Hackage repo. |
Member
|
Thanks, I released and tagged persistent-redis and persistent-test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1107.
I am not sure about the use ofAfter some research I believe this is handled by Template Haskell, as it should be.Typeablein persistent-template/Database/Persist/TH.hs. However, even if it is no longer needed, this may be out of scope for this PR.I hope I got the versions/changelogs right.
After submitting your PR:
(unreleased)on the Changelog