Merged
Conversation
friedbrice
reviewed
Nov 4, 2020
| -- insert one or more rows, you need to use 'valuesToInsert entity' to | ||
| -- generate the list of values that you feed into your prepared | ||
| -- statement so that generated columns are properly scrubbed. | ||
| valuesToInsert :: PersistEntity entity => entity -> [PersistValue] |
Contributor
There was a problem hiding this comment.
I'm glad you changed this, because I just realized it introduces a bug in the Sqlite backend where adding a generated= attribute to a field (correctly) didn't make the field generated in the schema but (incorrectly) did redact the value when binding to a prepared statement <.<;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
@sincedeclarations to the HaddockAfter submitting your PR:
(unreleased)on the Changelog