Replace askLogFunc with askLoggerIO#1162
Conversation
parsonsmatt
left a comment
parsonsmatt
left a comment
There was a problem hiding this comment.
Thanks for the PR! I think it'd be best if we made an issue for this and tagged it in for the next major version bump. It doesn't seem like a large enough change to release all on it's own right now.
| -- @since 2.1.3 | ||
| createPostgresqlPoolModified | ||
| :: (MonadUnliftIO m, MonadLogger m) | ||
| :: (MonadUnliftIO m, MonadLoggerIO m) |
There was a problem hiding this comment.
Changing the signature of these functions is a breaking change and would require a major version bump.
| ## 2.11.0.1 | ||
|
|
||
| * [#1162](https://github.com/yesodweb/persistent/pull/1162) | ||
| * Replace `askLogFunc` with `askLoggerIO` |
There was a problem hiding this comment.
2.11.0.1 has already been released on Hackage - since this is a breaking change, it'd need to go under 2.12 or 3.0.
Agreed. To do that, do I just need to put this change under 2.12 in the changelog? Also wasn't sure how to get CI building, looks like a github actions thing |
|
I fixed CI on master, try merging that in. I'm hesitant to release 2.12 with only this change, and I'd prefer to batch it up in the next breaking release. |
3 participants
Just trying to do a small FIXME here
no haddock changes
After submitting your PR: