Add QoL API for using BaseBackend/BackendCompatible#1178
Merged
parsonsmatt merged 6 commits intoyesodweb:masterfrom Jan 6, 2021
Merged
Add QoL API for using BaseBackend/BackendCompatible#1178parsonsmatt merged 6 commits intoyesodweb:masterfrom
parsonsmatt merged 6 commits intoyesodweb:masterfrom
Conversation
'withBaseBackend' and 'withCompatibleBackend' are simple wrappers for 'withReaderT' that use the appropriate read-transforming function from their respective instances. Also dogfoods these functions into the codebase.
parsonsmatt
approved these changes
Jan 6, 2021
Collaborator
parsonsmatt
left a comment
parsonsmatt
left a comment
There was a problem hiding this comment.
This is awesome, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
withBaseBackendandwithCompatibleBackendare simple wrappers forwithReaderTthat use the appropriate read-transforming function from their respective instances.Also dogfoods these functions into the codebase.
Before submitting your PR, check that you've:
@sincedeclarations to the HaddockAfter submitting your PR:
(unreleased)on the Changelog