Merged
Conversation
Collaborator
|
I've fixed CI, mind rebasing and trying again? |
parsonsmatt
reviewed
Mar 9, 2021
| , (1007, listOf PersistInt64) | ||
| , (1009, listOf PersistText) | ||
| , (143, listOf PersistText) | ||
| , (143, listOf (PersistByteString . unUnknown)) |
Collaborator
There was a problem hiding this comment.
Interesting.
So, based on what you're saying - the xml type shouldn't ever have worked, right? So no existing working code should be affected by this change?
parsonsmatt
approved these changes
Mar 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converting
sqltype=xmlvalues into Haskell types seem to fail:This is because Persistent tries to parse it as
PersistText(using theDatabase.PostgreSQL.Simple.FromFieldinstance ofText), however the oid ofxml, 142, does not match the oid's ofname,text,char,bpcharorvarchar, resulting in anIncompatibleerror.To fix this, I simply changed the type from
Textto (unknown)ByteString.Before submitting your PR, check that you've:
@sincedeclarations to the HaddockAfter submitting your PR:
(unreleased)on the Changelog