Skip to content

Fixing Haddock formatting for a new method#1228

Merged
parsonsmatt merged 3 commits intoyesodweb:masterfrom
dmarticus:1227
Apr 20, 2021
Merged

Fixing Haddock formatting for a new method#1228
parsonsmatt merged 3 commits intoyesodweb:masterfrom
dmarticus:1227

Conversation

@dmarticus
Copy link
Contributor

@dmarticus dmarticus commented Apr 14, 2021

This change fixes #1227

Before submitting your PR, check that you've:

  • Documented new APIs with Haddock markup
  • Added @since declarations to the Haddock
  • Ran stylish-haskell on any changed files.
  • Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

[record] -> -- ^ A list of the records you want to insert, or update
[HandleUpdateCollision record] -> -- ^ A list of the fields you want to copy over.
[Update record] -> -- ^ A list of the updates to apply that aren't dependent on the record being inserted.
[Filter record] -> -- ^ A filter condition that dictates the scope of the updates
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That really fixes it? I'm surprised. Do you have a screenshot of before and after?

@parsonsmatt parsonsmatt merged commit 69fa44a into yesodweb:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix formatting for upsertManyWhere haddock

2 participants