Remove nonEmptyOrFail function from recent tests#1237
Merged
parsonsmatt merged 4 commits intoyesodweb:masterfrom Apr 26, 2021
Merged
Remove nonEmptyOrFail function from recent tests#1237parsonsmatt merged 4 commits intoyesodweb:masterfrom
parsonsmatt merged 4 commits intoyesodweb:masterfrom
Conversation
danbroooks
commented
Apr 20, 2021
| `shouldBe` | ||
| ( [NEL.toList helloWorldTokens, NEL.toList foobarbazTokens], mempty ) | ||
| it "works4" $ do | ||
| let foobarbarz = ["foo", "Bar", "baz"] |
Contributor
Author
There was a problem hiding this comment.
These were also causing some type ambiguity errors, where with OverloadedLists we want to use this value here both as a [Text] and NonEmpty Text, so I have opted to re-writing the test with literals rather than trying to re-use the values. I've tried to include some more realworld looking values too while changing things here.
parsonsmatt
approved these changes
Apr 22, 2021
Collaborator
parsonsmatt
left a comment
parsonsmatt
left a comment
There was a problem hiding this comment.
looks great thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
@sincedeclarations to the Haddockstylish-haskellon any changed files..editorconfigfile for details)After submitting your PR:
(unreleased)on the ChangelogRemoves the
nonEmptyOrFailfunction in favour of making use ofOverloadedListsafter changes in #1231