Skip to content

Support GHC 9#1265

Merged
parsonsmatt merged 17 commits intomasterfrom
matt/support-ghc-9
May 24, 2021
Merged

Support GHC 9#1265
parsonsmatt merged 17 commits intomasterfrom
matt/support-ghc-9

Conversation

@parsonsmatt
Copy link
Collaborator

@parsonsmatt parsonsmatt commented May 7, 2021 •
edited
Loading

Before submitting your PR, check that you've:

  • Documented new APIs with Haddock markup
  • Added @since declarations to the Haddock
  • Ran stylish-haskell on any changed files.
  • Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)
  • Check for Hedis release

@parsonsmatt
Copy link
Collaborator Author

parsonsmatt commented May 7, 2021

Currently blocked on swamp-agr/blaze-textual#14 as a transitive dependency of persistent-mysql via mysql-simple. mysql-simple patch as a work-around: paul-rouse/mysql-simple#51

@parsonsmatt
Copy link
Collaborator Author

parsonsmatt commented May 7, 2021

Blocked on memory, issue: vincenthz/hs-memory#84 two PRs up to fix the problem

@parsonsmatt
Copy link
Collaborator Author

parsonsmatt commented May 7, 2021 •
edited
Loading

persistent-redis is blocked on hedis which is blocked on the above memory release as well as cryptonite, which is also blocked on memory. cryptonite has a draft PR to fix it: haskell-crypto/cryptonite#338

hedis pr: informatikr/hedis#170

parsonsmatt
parsonsmatt commented May 7, 2021
View reviewed changes
persistent-sqlite/Database/Persist/Sqlite.hs
#if MIN_VERSION_base(4,12,0)
$(pure [])

makeCompatibleInstances [t| forall b. Compatible b (RawSqlite b) |]
Copy link
Collaborator Author

@parsonsmatt parsonsmatt May 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makeCompatibleInstances is complaining about the above instances not being visible here due to the way top level declaration groups have been changed.

parsonsmatt
parsonsmatt commented May 7, 2021
View reviewed changes
Copy link
Collaborator Author

@parsonsmatt parsonsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty straightforward changes, some warning cleanup as well

@parsonsmatt parsonsmatt mentioned this pull request May 7, 2021
Closed
@parsonsmatt parsonsmatt linked an issue May 7, 2021 that may be closed by this pull request
Benchmarks are broken #1267
Closed
@parsonsmatt parsonsmatt marked this pull request as draft May 7, 2021 18:25
@parsonsmatt
Copy link
Collaborator Author

parsonsmatt commented May 10, 2021

@parsonsmatt parsonsmatt mentioned this pull request May 11, 2021
Closed
@parsonsmatt parsonsmatt marked this pull request as ready for review May 21, 2021 16:09
@parsonsmatt parsonsmatt merged commit e8387eb into master May 24, 2021
@parsonsmatt parsonsmatt deleted the matt/support-ghc-9 branch May 24, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Benchmarks are broken

1 participant

@parsonsmatt