Skip to content

Support declaring Maybe before the type (continuation)#1292

Merged
parsonsmatt merged 2 commits intomasterfrom
matt/maybe-before-type
Jun 29, 2021
Merged

Support declaring Maybe before the type (continuation)#1292
parsonsmatt merged 2 commits intomasterfrom
matt/maybe-before-type

Conversation

@parsonsmatt
Copy link
Collaborator

Before submitting your PR, check that you've:

  • Documented new APIs with Haddock markup
  • Added @since declarations to the Haddock
  • Ran stylish-haskell on any changed files.
  • Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Continuation of #1264

Closes #277

danbroooks and others added 2 commits June 29, 2021 07:28
* Add missing type sigs

* Extract/dry up is nullable

* Extract/rename associateComments function

* Implement a way of detecting Maybe field defs

* Fixing warnings

* Add a spec

* Add documentation

* Add PR reference to changelog

* Add a test to cover the various backends

* Also test mongo

* Fix test compilation issues

* Update readme

Co-authored-by: Matt Parsons <[email protected]>
@parsonsmatt parsonsmatt merged commit 85fcfe8 into master Jun 29, 2021
@parsonsmatt parsonsmatt deleted the matt/maybe-before-type branch June 29, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support Maybe before the type

2 participants