Expose orderClause from PersistQuery.hs#1317
Merged
parsonsmatt merged 2 commits intoyesodweb:masterfrom Oct 7, 2021
SupercedeTech:expose-orderClause
Merged
Expose orderClause from PersistQuery.hs#1317parsonsmatt merged 2 commits intoyesodweb:masterfrom SupercedeTech:expose-orderClause
parsonsmatt merged 2 commits intoyesodweb:masterfrom
SupercedeTech:expose-orderClause
Conversation
This is part of the followup to #1298. This exposes `orderClause` in a similar manner to `filterClause`, to help third-party libraries which want to format their own SQL queries using Persistent's internal helpers. It rewrites `orderClause` a bit to bring it in line with the other exposed functions, but there should be no functional changes as a result.
parsonsmatt
approved these changes
Oct 7, 2021
Collaborator
parsonsmatt
left a comment
parsonsmatt
left a comment
There was a problem hiding this comment.
looks good, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of the followup to #1298.
This exposes
orderClausein a similar manner tofilterClause, to help third-party libraries which want to format their own SQL queries using Persistent's internal helpers.It rewrites
orderClausea bit to bring it in line with the other exposed functions, but there should be no functional changes as a result.Before submitting your PR, check that you've:
@sincedeclarations to the Haddockstylish-haskellon any changed files..editorconfigfile for details)After submitting your PR:
(unreleased)on the Changelog