Replace (IORef (Map Text Statement)) with StatementCache interface#1327
Closed
iand675 wants to merge 8 commits intoyesodweb:masterfrom
Closed
Replace (IORef (Map Text Statement)) with StatementCache interface#1327iand675 wants to merge 8 commits intoyesodweb:masterfrom
iand675 wants to merge 8 commits intoyesodweb:masterfrom
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, I've observed that the existing statement cache can leak memory, since it never clears statements from the cache. This PR adds support for providing alternative implementations of the statement cache & monitoring size in order to handle/discover these potential memory leaks.
Before submitting your PR, check that you've:
@sincedeclarations to the Haddockstylish-haskellon any changed files..editorconfigfile for details)After submitting your PR:
(unreleased)on the Changelog