Skip to content

Replace (IORef (Map Text Statement)) with StatementCache interface#1327

Closed
iand675 wants to merge 8 commits intoyesodweb:masterfrom
iand675:statement-cache
Closed

Replace (IORef (Map Text Statement)) with StatementCache interface#1327
iand675 wants to merge 8 commits intoyesodweb:masterfrom
iand675:statement-cache

Conversation

@iand675
Copy link
Contributor

@iand675 iand675 commented Oct 9, 2021

In some cases, I've observed that the existing statement cache can leak memory, since it never clears statements from the cache. This PR adds support for providing alternative implementations of the statement cache & monitoring size in order to handle/discover these potential memory leaks.

Before submitting your PR, check that you've:

  • Documented new APIs with Haddock markup
  • Added @since declarations to the Haddock
  • Ran stylish-haskell on any changed files.
  • Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@parsonsmatt parsonsmatt added this to the 2.14 milestone Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants