Don't discover constrained instances#1329
Merged
parsonsmatt merged 2 commits intoyesodweb:masterfrom Oct 13, 2021
Merged
Conversation
parsonsmatt
approved these changes
Oct 13, 2021
Collaborator
parsonsmatt
left a comment
parsonsmatt
left a comment
There was a problem hiding this comment.
Let's call this a patch version bump. There's no way this would have worked out previously, so the behavior change is strictly going to allow more programs to work successfully than otherwise. Do you mind adding the changelog entry and cabal file bumps?
| getDecType dec = | ||
| case dec of | ||
| InstanceD _moverlap _cxt typ _decs -> | ||
| InstanceD _moverlap [] typ _decs -> |
Collaborator
There was a problem hiding this comment.
this kicks ass thanks!
Contributor
Author
Not at all, just gotta learn how to do that. brb EDIT: ok, does that look right? |
Collaborator
|
released as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The big idea here is that if a user or something besides
Database.Persist.THwrites aC a => PersistEntity (Foo a)instance, we don't wantdiscoverEntitiesto find it and include aentityDef (Proxy :: Proxy (Foo a))in the list, because there's no way that's going to work (unlessCis a trivial typeclass).Before submitting your PR, check that you've:
Documented new APIs with Haddockmarkup
Added@sincedeclarations
to the Haddock
stylish-haskellon any changed files..editorconfigfile for details)After submitting your PR:
(unreleased)on the Changelog