Skip to content

Remove SomePersistField#1346

Merged
parsonsmatt merged 2 commits intoyesodweb:masterfrom
halogenandtoast:halogenandtoast/remove-some-persist-field
Apr 12, 2022
Merged

Remove SomePersistField#1346
parsonsmatt merged 2 commits intoyesodweb:masterfrom
halogenandtoast:halogenandtoast/remove-some-persist-field

Conversation

@halogenandtoast
Copy link
Contributor

@halogenandtoast halogenandtoast commented Dec 14, 2021

Issue

SomePersistField exists only to convert to PersistValue. Furthermore, we end up with a type-class instance with unexpected behavior due to how fromPersistValue works.

Solution

We can replace SomePersistValue with PersistValue directly.

After submitting your PR:

N.B.

Yesod book's description for the generated code should be updated as well.

TODO For Author

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@parsonsmatt parsonsmatt added this to the 2.14 milestone Dec 14, 2021
@parsonsmatt parsonsmatt merged commit ea09601 into yesodweb:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants