aeson 2.0 support (only)#1351
Merged
parsonsmatt merged 4 commits intoyesodweb:masterfrom Jan 20, 2022
Merged
Conversation
parsonsmatt
approved these changes
Jan 20, 2022
Collaborator
parsonsmatt
left a comment
parsonsmatt
left a comment
There was a problem hiding this comment.
Thank you so much! I'll get a release out soon.
| extra-deps: | ||
| - lift-type-0.1.0.0 | ||
| - aeson-2.0.2.0 | ||
| # https://github.com/yesodweb/shakespeare/pull/260 |
Contributor
There was a problem hiding this comment.
This is extraneous, from a bad cherry-pick. Resolved here: https://github.com/yesodweb/persistent/pull/1338/files#diff-0de01f189d384bfbe69e806ef70b1a425b27394dbe2a9d0e62ffd010dda86c03L15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #1344
Cherry-picks from #1335 and #1338
seems like GHC 9.2 support for dependencies could take a while, so I would appreciate an earlier release with only aeson 2 support.
The Arbitrary Value instance in the pg tests was more restrictive than the one in aeson 2.0.3.0 so i newtyped it.