Further integer types in migration idempotency test#1359
Merged
paul-rouse merged 4 commits intoyesodweb:masterfrom Mar 11, 2022
Merged
Further integer types in migration idempotency test#1359paul-rouse merged 4 commits intoyesodweb:masterfrom
paul-rouse merged 4 commits intoyesodweb:masterfrom
Conversation
Contributor
Author
|
The additional test passes now (after #1360), so merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extra fields in the migration idempotency test are intended to show the problem in #1358, and test the fix which will come separately. Before that fix is applied, the test is expected to fail when run against MySQL 8.
I have kept this PR separate from the fix since it is run for other backends too, making it somewhat independent.
Before submitting your PR, check that you've:
stylish-haskellon any changed files..editorconfigfile for details)After submitting your PR:
(unreleased)on the Changelog