Skip to content

Further integer types in migration idempotency test#1359

Merged
paul-rouse merged 4 commits intoyesodweb:masterfrom
paul-rouse:idempotency-test
Mar 11, 2022
Merged

Further integer types in migration idempotency test#1359
paul-rouse merged 4 commits intoyesodweb:masterfrom
paul-rouse:idempotency-test

Conversation

@paul-rouse
Copy link
Contributor

@paul-rouse paul-rouse commented Feb 9, 2022

The extra fields in the migration idempotency test are intended to show the problem in #1358, and test the fix which will come separately. Before that fix is applied, the test is expected to fail when run against MySQL 8.

I have kept this PR separate from the fix since it is run for other backends too, making it somewhat independent.

Before submitting your PR, check that you've:

  • Ran stylish-haskell on any changed files.
  • Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts) - the current failure is the expected one!

@paul-rouse
Copy link
Contributor Author

The additional test passes now (after #1360), so merging.

@paul-rouse paul-rouse merged commit 647b617 into yesodweb:master Mar 11, 2022
@paul-rouse paul-rouse deleted the idempotency-test branch March 11, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant