Skip to content

Add spec to assert Persistent.TH is the only import required when defining entities#1370

Merged
parsonsmatt merged 3 commits intoyesodweb:masterfrom
danbroooks:persist-imports-spec
Mar 15, 2022
Merged

Add spec to assert Persistent.TH is the only import required when defining entities#1370
parsonsmatt merged 3 commits intoyesodweb:masterfrom
danbroooks:persist-imports-spec

Conversation

@danbroooks
Copy link
Contributor

@danbroooks danbroooks commented Mar 15, 2022

Follow on from #1369. Though that PR adds some additional coverage to prevent this from happening again, this PR adds an additional spec to explicitly verify we can generate entities where Data.Persistent.TH is the only import required.

Screenshot from 2022-03-15 18-22-35


Before submitting your PR, check that you've:

  • Documented new APIs with Haddock markup
  • Added @since declarations to the Haddock
  • Ran stylish-haskell on any changed files.
  • Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Copy link
Collaborator

@parsonsmatt parsonsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🙌🏻

@parsonsmatt parsonsmatt merged commit aeaa4f6 into yesodweb:master Mar 15, 2022
@danbroooks danbroooks deleted the persist-imports-spec branch March 16, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants