Skip to content

Add coverage for parsing nested parens/lists in field types#1376

Merged
parsonsmatt merged 4 commits intoyesodweb:masterfrom
danbroooks:quasi-parser-tests
Mar 21, 2022
Merged

Add coverage for parsing nested parens/lists in field types#1376
parsonsmatt merged 4 commits intoyesodweb:masterfrom
danbroooks:quasi-parser-tests

Conversation

@danbroooks
Copy link
Contributor

@danbroooks danbroooks commented Mar 19, 2022

Adds some test coverage to the FieldType parser that I noticed was not currently covered by tests currently. Specifically around the nesting of parens and square brackets. I was spiking a refactor of the parser in Quasi, and my implementation failed to parse this kind of thing while the current one does parse this successfully, so I thought it was worthwhile submitting this as increased coverage that can be merged into master to cover any future changes.


Before submitting your PR, check that you've:

  • Documented new APIs with Haddock markup
  • Added @since declarations to the Haddock
  • Ran stylish-haskell on any changed files.
  • Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Copy link
Collaborator

@parsonsmatt parsonsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome~

@parsonsmatt parsonsmatt merged commit f2e930f into yesodweb:master Mar 21, 2022
@danbroooks danbroooks deleted the quasi-parser-tests branch March 29, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants