Add coverage for parsing nested parens/lists in field types#1376
Merged
parsonsmatt merged 4 commits intoyesodweb:masterfrom Mar 21, 2022
Merged
Add coverage for parsing nested parens/lists in field types#1376parsonsmatt merged 4 commits intoyesodweb:masterfrom
parsonsmatt merged 4 commits intoyesodweb:masterfrom
Conversation
3e3d38a to
6a9a363
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some test coverage to the FieldType parser that I noticed was not currently covered by tests currently. Specifically around the nesting of parens and square brackets. I was spiking a refactor of the parser in
Quasi, and my implementation failed to parse this kind of thing while the current one does parse this successfully, so I thought it was worthwhile submitting this as increased coverage that can be merged into master to cover any future changes.Before submitting your PR, check that you've:
@sincedeclarations to the Haddockstylish-haskellon any changed files..editorconfigfile for details)After submitting your PR:
(unreleased)on the Changelog