Clarify error message wording#1438
Merged
parsonsmatt merged 3 commits intoyesodweb:masterfrom Dec 2, 2022
friedbrice:friedbrice/clarify-error-message-wording-for-nullable-uniqueness-constraint-warning
Merged
Clarify error message wording#1438parsonsmatt merged 3 commits intoyesodweb:masterfrom friedbrice:friedbrice/clarify-error-message-wording-for-nullable-uniqueness-constraint-warning
parsonsmatt merged 3 commits intoyesodweb:masterfrom
friedbrice:friedbrice/clarify-error-message-wording-for-nullable-uniqueness-constraint-warning
Conversation
parsonsmatt
approved these changes
Dec 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just suggesting a wording change on the warning message when trying to add a uniqueness constraint to a nullable column.
Some people were confused about whether this warning came from our in-house code or from Persistent, so I clarified that. Also, some people were confused about whose equality semantics treated nulls as not equal, so I clarified that it's a SQL thing.