Default impl for insert_ that does not do a secondary query#1449
Merged
parsonsmatt merged 2 commits intomasterfrom Dec 5, 2022
Merged
Default impl for insert_ that does not do a secondary query#1449parsonsmatt merged 2 commits intomasterfrom
parsonsmatt merged 2 commits intomasterfrom
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1441
This is a patch-level PR that swaps out the default implementation of
insert_for one that does not perform a secondary query. In local testing, this fixes the issue whereinsertandinsert_take the same amount of time for SQLite. All tests pass locally forpostgresql. There is likely not a performance benefit for Postgres since it';sa ble to doinsert ... returning ... However, the code never demands the result, so it is probably not parsed.Before submitting your PR, check that you've:
@sincedeclarations to the Haddockstylish-haskellon any changed files..editorconfigfile for details)After submitting your PR:
(unreleased)on the Changelog