Make use of CautiousMigration type alias in SQL backends.#1459
Make use of CautiousMigration type alias in SQL backends.#1459parsonsmatt merged 1 commit intoyesodweb:masterfrom
CautiousMigration type alias in SQL backends.#1459Conversation
|
Bump. This PR is trivial, can we get it merged in? |
|
sure! please update the changelog, bump the version bound, and I'll prepare a release. |
arrowd
force-pushed
the
CautiousMigration
branch
from
33dceef to
0d93670
Compare
|
Ouch, I should've bumped backend packages, not |
|
Yup - |
* Bump persistent-mysql, persistent-postgresql and persistent-sqlite versions. * Update respective changelogs.
arrowd
force-pushed
the
CautiousMigration
branch
from
0d93670 to
978c4f0
Compare
|
Another bump. |
|
It is disappointing to see such trivial PR taking so long to get in. I have other small changes in queue that I'm hoping to upstream. |
|
I understand your frustration. My work and personal situation do not leave much time or energy for OSS maintenance right now. With this PR merged, your future PRs should automatically have CI run for them, which will speed things up a good bit. For future PRs, please don't delete the PR template. |
Yes, we're all volunteers here. I appreciate the time you took for this review.
Ok, noted. Thanks! |
2 participants
When reading
migrate'implementations ofpersistent-sqliteandpersistent-postgresqlit took me a while to figure out what(Bool, Text)actually means. Using the type alias fromDatabase.Persist.Sql.Migrationmakes it clearer.