fix a problem preventing use of Primary with NoFieldselectors#1460
Merged
parsonsmatt merged 2 commits intoyesodweb:masterfrom Jan 5, 2023
Merged
fix a problem preventing use of Primary with NoFieldselectors#1460parsonsmatt merged 2 commits intoyesodweb:masterfrom
parsonsmatt merged 2 commits intoyesodweb:masterfrom
Conversation
parsonsmatt
approved these changes
Jan 5, 2023
Collaborator
parsonsmatt
left a comment
There was a problem hiding this comment.
great catch, thank you!
Collaborator
|
released and uploaded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a couple of places where it still generates code using selector functions; this PR replaces them with
fieldSel.Before submitting your PR, check that you've:
@sincedeclarations to the Haddockstylish-haskellon any changed files..editorconfigfile for details)After submitting your PR:
(unreleased)on the Changelog