Remove extraneous map toPersistValue call.#1468
Merged
parsonsmatt merged 1 commit intoyesodweb:masterfrom Feb 1, 2023
Merged
Conversation
Contributor
Author
|
Bump. This is a trivial one-line PR. |
Collaborator
|
Good catch, thank you! Please add a changelog entry, under a new |
The list produced by `toPersistFields entity` is already of type `[PersistValue]`.
arrowd
force-pushed
the
extra-topersistvalue
branch
from
80f9471 to
ac12a40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The list produced by
toPersistFields entityis already of type[PersistValue]. This can be checked by putting a type hole inside, which will reveal thattoPersistValuecall in this context hasPersistValue -> PersistValuetype and boils down toid.Before submitting your PR, check that you've:
stylish-haskellon any changed files..editorconfigfile for details)After submitting your PR: