Skip to content

add Database.Sqlite.open' which takes a ByteString#1486

Merged
parsonsmatt merged 2 commits intoyesodweb:masterfrom
joeyh:master
Oct 4, 2023
Merged

add Database.Sqlite.open' which takes a ByteString#1486
parsonsmatt merged 2 commits intoyesodweb:masterfrom
joeyh:master

Conversation

@joeyh
Copy link
Contributor

@joeyh joeyh commented Mar 23, 2023

This allows using a sqlite database that is in a directory whose name cannot be expressed using Text.

Fixes #1481

Eventually it would make sense for open to use OsPath, but the Abstract FilePath Proposal is still rolling out. In the meantime, this avoids an API change for users of open.

Before submitting your PR, check that you've:

  • Documented new APIs with Haddock markup
  • Added @since declarations to the Haddock
  • Ran stylish-haskell on any changed files.
  • Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

This allows using a sqlite database that is in a directory whose name
cannot be expressed using Text.

Fixes #1481
Copy link
Collaborator

@parsonsmatt parsonsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will release in another minor version

@parsonsmatt parsonsmatt merged commit b2b5c32 into yesodweb:master Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Database.Sqlite.open should not use Text for directory name

2 participants