Use fresh, unshadowed names for the field patterns#1494
Closed
merijn wants to merge 1 commit intoyesodweb:masterfrom
Closed
Use fresh, unshadowed names for the field patterns#1494merijn wants to merge 1 commit intoyesodweb:masterfrom
merijn wants to merge 1 commit intoyesodweb:masterfrom
Conversation
Change the generation code for keyFromRecordM to generate fresh, uncaptured variable names for the patterns it generates. Fixes yesodweb#1493.
4 tasks
hw202207
added a commit
to hw202207/persistent
that referenced
this pull request
Jun 1, 2023
- got the idea from yesodweb#1494
parsonsmatt
pushed a commit
that referenced
this pull request
Jun 27, 2023
* Fixes name shadowing error at keyFromRecordM for Primary keys * Address comments - use newName instead of mkName to create variable - got the idea from #1494 * Update changelog * Fixes the link in the change log
Collaborator
|
Closed in favor of #1496 - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the generation code for keyFromRecordM to generate fresh, uncaptured variable names for the patterns it generates. Fixes #1493.