Skip to content

Allow Integral types to parse PersistRational#1528

Merged
parsonsmatt merged 6 commits intomasterfrom
mattvh/integral-numeric
Feb 8, 2024
Merged

Allow Integral types to parse PersistRational#1528
parsonsmatt merged 6 commits intomasterfrom
mattvh/integral-numeric

Conversation

@parsonsmatt
Copy link
Collaborator

This issue addresses #1527

If the denominator is 1, then we allow it. Otherwise, we go boom.

This should fix the issue with esqueleto.

Before submitting your PR, check that you've:

  • Documented new APIs with Haddock markup
  • Added @since declarations to the Haddock
  • Ran stylish-haskell on any changed files.
  • Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@parsonsmatt parsonsmatt merged commit 9701360 into master Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant