Document mpsFieldLabelModifier with example#1587
Merged
parsonsmatt merged 6 commits intoyesodweb:masterfrom May 7, 2025
Merged
Document mpsFieldLabelModifier with example#1587parsonsmatt merged 6 commits intoyesodweb:masterfrom
parsonsmatt merged 6 commits intoyesodweb:masterfrom
Conversation
Contributor
Author
|
@parsonsmatt i hope i'm not pinging too much. If there's a better process for you, i'm open for it. |
Collaborator
|
No, please ping me as often as you need - my apologies for not responding more promptly! |
parsonsmatt
reviewed
May 6, 2025
Collaborator
parsonsmatt
left a comment
parsonsmatt
left a comment
There was a problem hiding this comment.
Just need to move the @since down and this is good 👍🏻 Thanks!
Co-authored-by: Matt Parsons <[email protected]>
Co-authored-by: Matt Parsons <[email protected]>
dtpowl
pushed a commit
to dtpowl/persistent
that referenced
this pull request
May 15, 2025
* Document mpsFieldLabelModifier with example * Update persistent/Database/Persist/TH/Internal.hs Co-authored-by: Matt Parsons <[email protected]> * Update persistent/Database/Persist/TH/Internal.hs Co-authored-by: Matt Parsons <[email protected]> * Move @SInCE to bottom * Rephrase pragma recommendation * Add changelog --------- Co-authored-by: Matt Parsons <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found the documentation for
mpsFieldLabelModifierharder to understand than necessary. So let's fix it. A PR formpsConstraintLabelModifiermight follow.Before submitting your PR, check that you've:
@sincedeclarations to the Haddockfourmoluon any changed files (restyledwill do this for you, soaccept the suggested changes if it makes them)
.editorconfigandfourmolu.yamlfiles for details)After submitting your PR:
(unreleased)on the Changelog